Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FrameworkBundle] Wire inner translator #23370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2017
Merged

[FrameworkBundle] Wire inner translator #23370

merged 1 commit into from
Jul 4, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23293 (comment)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Jul 4, 2017
Closed
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 4, 2017
@fabpot
Copy link
Member

fabpot commented Jul 4, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit a32cae5 into symfony:3.4 Jul 4, 2017
fabpot added a commit that referenced this pull request Jul 4, 2017
@fabpot
bug #23370 [FrameworkBundle] Wire inner translator (ogizanagi)
a1c77e7 
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Wire inner translator

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #23293 (comment)
| License       | MIT
| Doc PR        | N/A

Commits
-------

a32cae5 [FrameworkBundle] Wire inner translator
@ogizanagi ogizanagi deleted the fix/3.4/wire_inner_warmable_translator branch July 4, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @fabpot @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.