[FrameworkBundle][Translator] Fix cache warmer translator lazy-loading #23293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
previously approved these changes
Jul 3, 2017
|
@ogizanagi starting with 3.3, can't we configure the injected service locator to use |
|
In fact, I propose to NOT merge this PR and let things as is. Yes, the warmer is not lazy when the logging translator is used, but at least warm up works. Starting with 3.3, see previous comment :) |
|
See #23370 I'm closing this one for the reasons explained above by @nicolas-grekas :) |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Wire inner translator | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23293 (comment) | License | MIT | Doc PR | N/A Commits ------- a32cae5 [FrameworkBundle] Wire inner translator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a bug fix, but in #23014, we expected to lazy load the cache warmer's translator by injecting the container instead. But the
LoggingTranslatorPassreplaces it, and it results in a deprecation raised in 3.4.The issue with this patch and the original PR intent however is that the translator you get from the container might be a decorated one (
DataCollectorTranslatorfor instance) which may not implementWarmableInterface, making the warmer ineffective...Considering #23014 issue mainly was about the
TemplateCacheWarmer, I'm torn between this patch, reverting changes inTranslationsCacheWarmeror finding some other ugly workarounds.