[Assets] Make templating.helper.assets service available again for BC reasons #13871
Conversation
|
👍 This is something which have broken one of my bundle too (See egeloen/IvoryCKEditorBundle#157) |
ca093c6 to
048cc8a
Compare
|
|
||
| <!-- | ||
| This should be in templating_php.xml but unfortunately, Twig depends on this helper. | ||
| As the Twig extension depending on this service is deprecated, this will be removed in 3.0. |
There was a problem hiding this comment.
Twig does not depend on it anymore, so the comment should be updated to reflect why we are adding this service here back.
There was a problem hiding this comment.
Done, not 100% sure if it's a really great sentence now though
048cc8a to
a133fbf
Compare
|
New comment looks good to me. @wouterj Can you also update the 3.0 UPGRADE file to mention the availability of this service? |
|
@fabpot I've added the removal (and its replacement) to the UPGRADE-3.0 file. I'm not sure if it's correct though (it's very difficult to follow the whole asset things with all its BC layers). |
|
Can this please be merged? It's holding up CMF's tests to check if it is future compatible. |
|
Thank you @wouterj. |
This service has always been available and the SonataDoctrinePhpcrOdmBundle relied on this services. Moving it to the templating_php config (which is only loaded when PHP templating is enabled, which is often not the case) is a BC break that makes it very hard to support <2.7 and 2.7.
This should be reverted for the 3.0 branch (master), as it should be removed in 3.0. However, it should be added to the
UPRADE-3.0.mdfile.