Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d872042

Browse filesBrowse files
fabpotfabpot
committed
bug #13871 [Assets] Make templating.helper.assets service available again for BC reasons (WouterJ)
This PR was squashed before being merged into the 2.7 branch (closes #13871). Discussion ---------- [Assets] Make templating.helper.assets service available again for BC reasons This service has always been available and the SonataDoctrinePhpcrOdmBundle relied on this services. Moving it to the templating_php config (which is only loaded when PHP templating is enabled, which is often not the case) is a BC break that makes it very hard to support <2.7 and 2.7. This should be reverted for the 3.0 branch (master), as it should be removed in 3.0. However, it should be added to the `UPRADE-3.0.md` file. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a4b7da5 [Assets] Make templating.helper.assets service available again for BC reasons
2 parents de658e7 + a4b7da5 commit d872042
Copy full SHA for d872042

File tree

Expand file treeCollapse file tree

3 files changed

+55
-7
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+55
-7
lines changed

‎UPGRADE-3.0.md

Copy file name to clipboardExpand all lines: UPGRADE-3.0.md
+45Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,51 @@ UPGRADE FROM 2.x to 3.0
326326
* The `request` service was removed. You must inject the `request_stack`
327327
service instead.
328328

329+
* The `templating.helper.assets` was moved to `templating_php.xml`. You can
330+
use the `assets.package` service instead.
331+
332+
Before:
333+
334+
```php
335+
use Symfony\Component\Templating\Helper\CoreAssetsHelper;
336+
337+
class DemoService
338+
{
339+
private $assetsHelper;
340+
341+
public function __construct(CoreAssetsHelper $assetsHelper)
342+
{
343+
$this->assetsHelper = $assetsHelper;
344+
}
345+
346+
public function testMethod()
347+
{
348+
return $this->assetsHelper->getUrl('thumbnail.png', null, $this->assetsHelper->getVersion());
349+
}
350+
}
351+
```
352+
353+
After:
354+
355+
```php
356+
use Symfony\Component\Asset\Packages;
357+
358+
class DemoService
359+
{
360+
private $assetPackages;
361+
362+
public function __construct(Packages $assetPackages)
363+
{
364+
$this->assetPackages = $assetPackages;
365+
}
366+
367+
public function testMethod()
368+
{
369+
return $this->assetPackages->getUrl('thumbnail.png').$this->assetPackages->getVersion();
370+
}
371+
}
372+
```
373+
329374
* The `enctype` method of the `form` helper was removed. You should use the
330375
new method `start` instead.
331376

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/templating.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/templating.xml
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<parameter key="templating.loader.cache.class">Symfony\Component\Templating\Loader\CacheLoader</parameter>
1515
<parameter key="templating.loader.chain.class">Symfony\Component\Templating\Loader\ChainLoader</parameter>
1616
<parameter key="templating.finder.class">Symfony\Bundle\FrameworkBundle\CacheWarmer\TemplateFinder</parameter>
17+
<parameter key="templating.helper.assets.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper</parameter>
1718
</parameters>
1819

1920
<services>
@@ -58,5 +59,14 @@
5859
</service>
5960

6061
<service id="templating.loader" alias="templating.loader.filesystem" />
62+
63+
<!--
64+
This service will be moved to templating_php.xml in version 3.0, it exists here for BC reasons.
65+
-->
66+
<service id="templating.helper.assets" class="%templating.helper.assets.class%">
67+
<tag name="templating.helper" alias="assets" />
68+
<argument /> <!-- default package -->
69+
<argument type="collection" /> <!-- named packages -->
70+
</service>
6171
</services>
6272
</container>

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/templating_php.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/templating_php.xml
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
<parameter key="templating.helper.translator.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\TranslatorHelper</parameter>
1616
<parameter key="templating.helper.form.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\FormHelper</parameter>
1717
<parameter key="templating.helper.stopwatch.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\StopwatchHelper</parameter>
18-
<parameter key="templating.helper.assets.class">Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper</parameter>
1918
<parameter key="templating.form.engine.class">Symfony\Component\Form\Extension\Templating\TemplatingRendererEngine</parameter>
2019
<parameter key="templating.form.renderer.class">Symfony\Component\Form\FormRenderer</parameter>
2120
<parameter key="templating.globals.class">Symfony\Bundle\FrameworkBundle\Templating\GlobalVariables</parameter>
@@ -66,12 +65,6 @@
6665
<argument type="service" id="translator" />
6766
</service>
6867

69-
<service id="templating.helper.assets" class="%templating.helper.assets.class%">
70-
<tag name="templating.helper" alias="assets" />
71-
<argument /> <!-- default package -->
72-
<argument type="collection" /> <!-- named packages -->
73-
</service>
74-
7568
<service id="templating.helper.form" class="%templating.helper.form.class%">
7669
<tag name="templating.helper" alias="form" />
7770
<argument type="service" id="templating.form.renderer" />

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.