Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] make templating.helper.router service available again for BC reasons #14793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 30, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14790
License MIT
Doc PR

@xabbuh
Copy link
Member Author

xabbuh commented May 30, 2015

We did the same for the templating.helper.assets service in #13871 and imho we should discuss if we need to do the same for the other helper service in templating_php.xml.

@xabbuh xabbuh added the Ready label May 30, 2015
@fabpot
Copy link
Member

fabpot commented Jun 1, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 95dcfa2 into symfony:2.7 Jun 1, 2015
fabpot added a commit that referenced this pull request Jun 1, 2015
…available again for BC reasons (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] make `templating.helper.router` service available again for BC reasons

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14790
| License       | MIT
| Doc PR        |

Commits
-------

95dcfa2 [FrameworkBundle] make `templating.helper.router` service available again for BC reasons
@xabbuh xabbuh deleted the issue-14790 branch June 1, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.