Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a61ca2d

Browse filesBrowse files
minor #64473 [Translation] Fix test failing without the intl extension (nicolas-grekas)
This PR was merged into the 6.4 branch. Discussion ---------- [Translation] Fix test failing without the intl extension | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT `MergeOperationTest` and `TargetOperationTest::testMovingMessagesToIntlDomainsKeepsCatalogueMetadata` fail on the Windows `minimal-exts` CI job, which runs without the `intl` extension: ``` Failed asserting that null is identical to Array ( 'foo' => 'bar' ). ``` `AbstractOperation::moveMessagesToIntlDomainsIfPossible()` is a no-op when `\MessageFormatter` is not available, so the `messages+intl-icu` domain and its copied metadata are never created and `getCatalogueMetadata()` returns `null`. The test, added in 489ec9a, is therefore missing an ``@requires` extension intl` guard, like the other intl-dependent tests of the component. Commits ------- 7833eb7 [Translation] Fix test failing without the intl extension
2 parents d1d087b + 7833eb7 commit a61ca2d
Copy full SHA for a61ca2d

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/Symfony/Component/Translation/Tests/Catalogue/AbstractOperationTestCase.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/Catalogue/AbstractOperationTestCase.php
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ public function testSourceAndTargetWithDifferentLocales()
8282
);
8383
}
8484

85+
/**
86+
* @requires extension intl
87+
*/
8588
public function testMovingMessagesToIntlDomainsKeepsCatalogueMetadata()
8689
{
8790
$target = new MessageCatalogue('en', ['messages' => ['foo' => 'bar']]);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.