Commit a61ca2d
committed
minor #64473 [Translation] Fix test failing without the intl extension (nicolas-grekas)
This PR was merged into the 6.4 branch.
Discussion
----------
[Translation] Fix test failing without the intl extension
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | -
| License | MIT
`MergeOperationTest` and `TargetOperationTest::testMovingMessagesToIntlDomainsKeepsCatalogueMetadata` fail on the Windows `minimal-exts` CI job, which runs without the `intl` extension:
```
Failed asserting that null is identical to Array ( 'foo' => 'bar' ).
```
`AbstractOperation::moveMessagesToIntlDomainsIfPossible()` is a no-op when `\MessageFormatter` is not available, so the `messages+intl-icu` domain and its copied metadata are never created and `getCatalogueMetadata()` returns `null`. The test, added in 489ec9a, is therefore missing an ``@requires` extension intl` guard, like the other intl-dependent tests of the component.
Commits
-------
7833eb7 [Translation] Fix test failing without the intl extension1 file changed
+3Lines changed: 3 additions & 0 deletions
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- src/Symfony/Component/Translation/Tests/Catalogue
Expand file treeCollapse file tree
Open diff view settings
Collapse file
src/Symfony/Component/Translation/Tests/Catalogue/AbstractOperationTestCase.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/Catalogue/AbstractOperationTestCase.php+3Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
82 | 82 | |
83 | 83 | |
84 | 84 | |
| 85 | + |
| 86 | + |
| 87 | + |
85 | 88 | |
86 | 89 | |
87 | 90 | |
|
0 commit comments