Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d1d087b

Browse filesBrowse files
minor #64472 [Mailer][Mailchimp] Fix tests on low-deps (nicolas-grekas)
This PR was merged into the 6.4 branch. Discussion ---------- [Mailer][Mailchimp] Fix tests on low-deps | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT The Mailchimp bridge fails on the `low-deps` job: ``` MandrillApiTransportTest::testInlineImageUsesContentIdAsName Error: Call to undefined method Symfony\Component\Mime\Email::addPart() ``` `Email::addPart()` was added in `symfony/mime` 6.2, but the bridge allows `symfony/mailer: ^5.4.21`, so `low-deps` installs `symfony/mime` 5.4. The inline-image tests added in 18d3054 rely on `addPart()`. This declares a conflict with `symfony/mime < 6.2`, consistently with the Sendgrid, Mailjet, Brevo and Sendinblue bridges which already do the same for the same reason. Commits ------- 4e21c1e [Mailer] [Mailchimp] Fix tests on low-deps
2 parents 6ae13cf + 4e21c1e commit d1d087b
Copy full SHA for d1d087b

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/Symfony/Component/Mailer/Bridge/Mailchimp/composer.json‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/Bridge/Mailchimp/composer.json
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
"require-dev": {
2323
"symfony/http-client": "^6.3|^7.0"
2424
},
25+
"conflict": {
26+
"symfony/mime": "<6.2"
27+
},
2528
"autoload": {
2629
"psr-4": { "Symfony\\Component\\Mailer\\Bridge\\Mailchimp\\": "" },
2730
"exclude-from-classmap": [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.