Use None as default Text width as in pyglet's Label + tests#2222
Merged
pushfoo merged 8 commits intoJul 8, 2024
developmentpythonarcade/arcade:developmentfrom
font-fixes-separate-from-2.1dev3pythonarcade/arcade:font-fixes-separate-from-2.1dev3Copy head branch name to clipboard
Merged
Use None as default Text width as in pyglet's Label + tests#2222pushfoo merged 8 commits intodevelopmentpythonarcade/arcade:developmentfrom font-fixes-separate-from-2.1dev3pythonarcade/arcade:font-fixes-separate-from-2.1dev3Copy head branch name to clipboard
pushfoo merged 8 commits into
developmentpythonarcade/arcade:developmentfrom
font-fixes-separate-from-2.1dev3pythonarcade/arcade:font-fixes-separate-from-2.1dev3Copy head branch name to clipboard
Conversation
* Add edge case handling by using not instead of == 0 * Update arcade.text.Text instance tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Use
width: int | None = Noneto follow upstream + testsThis is separates changes out from #2183 since that'll take a while to merge.
Changes
Noneas the defaultwidthitTextanddraw_textNonehandling