Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bump to pyglet == 2.1dev3#2183

Closed
pushfoo wants to merge 18 commits into
pythonarcade:developmentpythonarcade/arcade:developmentfrom
pushfoo:pyglet2.1dev3pushfoo/arcade:pyglet2.1dev3Copy head branch name to clipboard
Closed

Bump to pyglet == 2.1dev3#2183
pushfoo wants to merge 18 commits into
pythonarcade:developmentpythonarcade/arcade:developmentfrom
pushfoo:pyglet2.1dev3pushfoo/arcade:pyglet2.1dev3Copy head branch name to clipboard

Conversation

@pushfoo

@pushfoo pushfoo commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

EDIT: Moved to #2226

Big changes:

  1. Modified code to use pyglet.options object appropriately
  2. No more __eq__ deletion tricks
  3. Partly document and type the pyglet text stack's apparent secret undocumented support for partial bolding (yes, I tested this)

Other changes:

  • Sound annotations
  • Align & pyright's spec-violating ideas o on Literal for text
  • Document the apparent undocumented support for string bold values across non-win32 platforms
  • Use | None in a few places
  • Temp fix float vs int for window sizes (Apple supports these, apparently to simplify touch events)

To resolve:

  • Verify that the workaround for pyglet font loading changes work
  • Figure out the current actual state of Label's font return values
  • What's going in with italic?
  • The GUI stack & event handlers
  • Whatever's going with Screen types and pyglet's import trickery

@pushfoo pushfoo mentioned this pull request Jul 7, 2024
Draft
7 tasks
This was referenced Jul 8, 2024
Merged
Merged
@pushfoo

pushfoo commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'll be slicing bits and pieces of this as I can so we merge faster.

I need help with the GUI stack / event handlers (@eruvanos) and Window situation.

pushfoo added 18 commits July 8, 2024 15:34
@pushfoo
Bump to pyglet == 2.1dev3
fac3aeb
@pushfoo
Remove del trick for getting future vec behavior
11f7f4b
@pushfoo
Update to options object
2260613
@pushfoo
Switch arcade/__init__.py to use OOP options object
1e8e3af
@pushfoo
Convert applications.py to OOP pyglet options
93aee70
@pushfoo
Convert doc on headless to use options object
f37793d
@pushfoo
Fix a comment in arcade/__init__.py
5c06a06
@pushfoo
Update tests/__init__.py
e3c64db
@pushfoo
Fix formatting
d8041f8
@pushfoo
Type compatibility fix in controller db loading
33c9c87
@pushfoo
Use pyglet.media.Source instead of a Union type
96827d2
@pushfoo
Fix color typing in arcade.Text
6e9aa4d
@pushfoo
Ignore over-strict pyright Literal opinion
1faa9fe
@pushfoo
Attempt to patch up the font loader
db65d56
@pushfoo
Use new-style | None in application.Window.__init__
2c7d4ac
@pushfoo
Update some typing for set_fullscreen
4baacd3 
* Use new-style | None

* Add casting and TODO on resolving screen coord issues upstream

* Mention rounding issue in set_fullscreen
@pushfoo
Add temporary type ignore for font_size
41baf5c
@pushfoo
Update type + doc for arcade.text bold support
a815f69 
* Update top-level docstring

* Update bold setter & getter

* Update bold return types
@pushfoo pushfoo mentioned this pull request Jul 9, 2024
Merged
5 tasks
@pushfoo

pushfoo commented Jul 9, 2024

Copy link
Copy Markdown
Member Author

Closed in favor of #2226.

@pushfoo pushfoo closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pushfoo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.