Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update download.html to reflect the unit change#9639

Closed
andresdelfino wants to merge 3 commits into
python:masterpython/cpython:masterfrom
andresdelfino:patch-3andresdelfino/cpython:patch-3Copy head branch name to clipboard
Closed

Update download.html to reflect the unit change#9639
andresdelfino wants to merge 3 commits into
python:masterpython/cpython:masterfrom
andresdelfino:patch-3andresdelfino/cpython:patch-3Copy head branch name to clipboard

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Sep 29, 2018

Copy link
Copy Markdown
Contributor

See #4293.

Comment thread Doc/tools/templates/download.html Outdated

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented Nov 7, 2018

Copy link
Copy Markdown
Member

@JulienPalard: Would you mind to review this PR?

@andresdelfino

Copy link
Copy Markdown
Contributor Author

@JulienPalard could you take a look at this?

Comment thread Doc/tools/templates/download.html Outdated
@vstinner

Copy link
Copy Markdown
Member

An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process:
https://www.python.org/dev/peps/pep-0101/

@andresdelfino

Copy link
Copy Markdown
Contributor Author

An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process:
https://www.python.org/dev/peps/pep-0101/

I also think that documentation size isn't that important nowadays, but perhaps there's a rationale we are missing here?

@davidak

davidak commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

@andresdelfino there are regions here in germany where people only get very slow internet connections. So it makes a difference for them if it is 1 MB or 5 MB. But they might not be python developers...

@andresdelfino

Copy link
Copy Markdown
Contributor Author

@davidak thanks for the insight!

@vstinner I'd keep the file sizes. Let me know how do you want to proceed on this one and I'll update the PR.

@andresdelfino

Copy link
Copy Markdown
Contributor Author

@vstinner how should I proceed? Should I remove the file sizes or preserve them and fix the typo pointed by Serhiy?

@vstinner

Copy link
Copy Markdown
Member

@andresdelfino: Honestly, I'm very confused by this issue. I don't understand why it takes months to fix such trivial issue :-) I skip my turn and let others handle it, sorry :-(

@matrixise matrixise requested a review from JulienPalard May 6, 2019 17:19
@matrixise

matrixise commented May 6, 2019

Copy link
Copy Markdown
Member

With the commit of @vstinner (see 8c663fd#diff-9c9d6c705ef5234b89019a8310a89d21), we don't need to specify the unit because it's explicitly indicated in the table.

Moreover, the commit removes the ambiguity with the unit.

The best thing to do is removing the complete line with the detailed unit.

I am going to close your PR and will fix the line.

Thank you a lot for your PR and hope to see your next contributions in the future.

PS: Before closing this issue, I have discussed with @JulienPalard about this issue.

@matrixise matrixise closed this May 6, 2019
@andresdelfino andresdelfino deleted the patch-3 branch May 6, 2019 17:51
@andresdelfino

Copy link
Copy Markdown
Contributor Author

@matrixise thanks for the reply :)

@vstinner

Copy link
Copy Markdown
Member

The best thing to do is removing the complete line with the detailed unit. I am going to close your PR and will fix the line.

@matrixise: Would you mind to add a link to your fix here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.