Replace KB unit with KiB#4293
Conversation
There was a problem hiding this comment.
I'm not sure the difference between KB and KiB is important here.
There was a problem hiding this comment.
This file should be kept compatible with both Python 2.6 and Python >= 3.0.
Changing the output format will make harder comparing results between versions.
There was a problem hiding this comment.
This script is compatible with Python 2.7 (I didn't test Python 2.6).
If the output must be the same with the script in Python 2.7, I can update Python 2.7 as well.
@pitrou: Since you wrote the script, what do you think?
There was a problem hiding this comment.
This is approximate value.
|
It may be worth to correct also MB and GB (as in f8def28). But not all decimal prefixes can be changed. |
Done. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
There are cases where a space between digits and unit is missed, like 256KB.
There was a problem hiding this comment.
Are you sure the size in MB and MiB is the same? Are binary prefixes preferenced here?
There was a problem hiding this comment.
I'm quite sure that the file size were compute with an unit of 1024 * 1024 bytes, MiB.
There was a problem hiding this comment.
The size of epub-file in 3.7 is 5.426 MB or 5.175 MiB. 5.5 is closer to 5.426, but in any case this is an approximate estimation. The question is what unit is more human-readable. What units are used by a file manager in Windows and OS X?
There was a problem hiding this comment.
What units are used by a file manager in Windows and OS X?
https://blogs.msdn.microsoft.com/oldnewthing/20090611-00/?p=17933
"Explorer is just following existing practice. Everybody (to within experimental error) refers to 1024 bytes as a kilobyte, not a kibibyte."
I prefer KiB rather than KB since KiB is defined as 1024 bytes, whereas KB (or kB) may be 1000 or 1024 bytes.
The size of epub-file in 3.7 is 5.426 MB or 5.175 MiB. 5.5 is closer to 5.426, but in any case this is an approximate estimation.
I don't think that it's interesting to give the file size. If we want to keep it, maybe we should drop digits after the dot.
These numbers are likely outdated, it's very hard to keep them up to date.
There was a problem hiding this comment.
If Windows Explorer uses the multiplier 1024 but call it KB, it is good to use binary prefixes here. If it uses the multiplier 1000, perhaps it is better to use decimal prefixes.
There was a problem hiding this comment.
If it uses the multiplier 1000, perhaps it is better to use decimal prefixes.
I'm not aware of any application using decimal prefixes...
There was a problem hiding this comment.
The volume of hard disks usually is specified with decimal prefixes.
I just have tested, Windows uses binary multipliers (but decimal prefixes), thus it is better to use binary multipliers for getting the same numbers, but with correct binary prefixes.
There was a problem hiding this comment.
Hard drive manufacturers use decimal prefixes, all software I know of uses binary. That's most of the cause behind a 3 TB drive appearing as 2.7 GB to Windows/Linux.
That said, unless you actually care about byte-precision, 5.5 MB is mentally equivalent to 5.5 MiB, or 6 MB, or 5 MB.
|
Please look also on cases where unit is not separated by a space from a number. |
|
@serhiy-storchaka: "Please look also on cases where unit is not separated by a space from a number." Oh, I missed them. Right, there were many of them :-) I rebased and completed my PR. |
|
I found one place in Python where "kB" means 1000 B: the bz2 module. The compression level is the block size in number of 100,000 B. I replaced 100 kB with 100,000 B to prevent any risk of confusion. |
|
I chose to write "100,000 B" since it's what I found in the official bzip2 documentation: http://www.bzip.org/1.0.5/bzip2-manual-1.0.5.html#memory-management The flags -1 through -9 specify the block size to be 100,000 bytes through 900,000 bytes (the default) respectively. |
|
But writing some numbers (like |
kB (*kilo* byte) unit means 1000 bytes, whereas KiB ("kibibyte")
means 1024 bytes. KB was misused: replace kB or KB with KiB when
appropriate.
Same change for MB and GB which become MiB and GiB.
Change the output of Tools/iobench/iobench.py.
Round also the size of the documentation from 5.5 MB to 5 MiB.
|
I replaced "900,000 B" with "900,000 bytes". "B" unit is rarely written like that, usually it's more "bytes". |
kB (kilo byte) unit means 1000 bytes, whereas KiB ("kibibyte")
means 1024 bytes. KB was misused: replace kB or KB with KiB when
appropriate.
Same change for MB and GB which become MiB and GiB.
Change the output of Tools/iobench/iobench.py.
Round also the size of the documentation from 5.5 MB to 5 MiB.