bpo-33995: fix ssl tests when built with LibreSSL#8050
Closed
alanhuang122 wants to merge 3 commits into
Closed
bpo-33995: fix ssl tests when built with LibreSSL#8050alanhuang122 wants to merge 3 commits into
alanhuang122 wants to merge 3 commits into
Conversation
added 2 commits
July 2, 2018 09:56
LibreSSL handles setting minimum and maximum protocol
versions for SSL contexts differently than OpenSSL.
This commit adds ssl.TLSVersion.{MAX,MIN}IMUM_AVAILABLE
constants, and fixes test_min_max_version under LibreSSL.
95618c9 to
3a421eb
Compare
auvipy
approved these changes
Jul 15, 2018
Member
|
An alternative PR has been merged: PR #11510. I close this one. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibreSSL handles setting minimum and maximum protocol
versions for SSL contexts differently than OpenSSL.
This commit adds ssl.TLSVersion.{MAX,MIN}IMUM_AVAILABLE
constants, and fixes test_min_max_version under LibreSSL.
https://bugs.python.org/issue33995