Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-35045: Accept TLSv1 default in min max test#11510

Merged
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
tiran:bpo35045-ssl-crypto-policytiran/cpython:bpo35045-ssl-crypto-policyCopy head branch name to clipboard
Jan 18, 2019
Merged

bpo-35045: Accept TLSv1 default in min max test#11510
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
tiran:bpo35045-ssl-crypto-policytiran/cpython:bpo35045-ssl-crypto-policyCopy head branch name to clipboard

Conversation

@tiran

@tiran tiran commented Jan 10, 2019

Copy link
Copy Markdown
Member

Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue35045

Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

Copy link
Copy Markdown
Member

I tested manually and I confirm that this change fix test_ssl on my Fedora 29.

@vstinner vstinner merged commit 34de2d3 into python:master Jan 18, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-11611 is a backport of this pull request to the 3.7 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @tiran and @vstinner, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 34de2d312b3687994ddbc29adb66e88f672034c7 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2019
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this pull request Jan 18, 2019
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.