Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.7] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826)#7530

Merged
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-66f02aa-3.7miss-islington/cpython:backport-66f02aa-3.7Copy head branch name to clipboard
Jun 8, 2018
Merged

[3.7] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826)#7530
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-66f02aa-3.7miss-islington/cpython:backport-66f02aa-3.7Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 8, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • bugfix and test for fragile metavar handling in argparse (see
    bpo-24089, bpo-14046, bpo-25058, bpo-11874)
  • also fixes some incorrect tests that did not make 1-element tuples correctly
    (cherry picked from commit 66f02aa)

Co-authored-by: wim glenn wim.glenn@gmail.com

https://bugs.python.org/issue11874

@wimglenn @miss-islington
bpo-11874: fix assertion failure in argparse metavar handling (python…
9617eb4 
…GH-1826)

- bugfix and test for fragile metavar handling in argparse (see
  bpo-24089, bpo-14046, bpo-25058, bpo-11874)
- also fixes some incorrect tests that did not make 1-element tuples correctly
(cherry picked from commit 66f02aa)

Co-authored-by: wim glenn <wim.glenn@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2018
Merged
@miss-islington

miss-islington commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 842985f into python:3.7 Jun 8, 2018
@miss-islington

miss-islington commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-66f02aa-3.7 branch June 8, 2018 11:33
@ncoghlan ncoghlan mentioned this pull request Jun 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot @wimglenn
Morty Proxy This is a proxified and sanitized view of the page, visit original site.