[3.7] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826)#7527
Closed
miss-islington wants to merge 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-66f02aa-3.7miss-islington/cpython:backport-66f02aa-3.7Copy head branch name to clipboard
Closed
[3.7] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826)#7527miss-islington wants to merge 1 commit intopython:3.7python/cpython:3.7from miss-islington:backport-66f02aa-3.7miss-islington/cpython:backport-66f02aa-3.7Copy head branch name to clipboard
miss-islington wants to merge 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-66f02aa-3.7miss-islington/cpython:backport-66f02aa-3.7Copy head branch name to clipboard
Conversation
Contributor
Author
1 similar comment
Contributor
Author
ncoghlan
approved these changes
Jun 8, 2018
Contributor
|
@Mariatta I'm not entirely clear what happened here... I think my closing the PR in order to restart the CI by reopening it may have confused miss-islington. |
Contributor
|
#7530 worked the way we'd expect it to work |
Member
|
@ncoghlan Yeah that's the tricky part. miss-islington will delete the branch after the PR has been closed, whether merged or not 😄 So re-creating the PR is the way to go, which you already did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-24089, bpo-14046, bpo-25058, bpo-11874)
(cherry picked from commit 66f02aa)
Co-authored-by: wim glenn wim.glenn@gmail.com
https://bugs.python.org/issue11874