Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Non-working attempt to introduce := as an assignment operator #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Non-working attempt to introduce := as an assignment operator #6333

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4706836
Non-working attempt to introduce := as an assignment operator
Rosuav Apr 1, 2018
7a60e19
Make := non-breaking but ignored (it's just the expression)
Rosuav Apr 2, 2018
f480ded
Implement some sort of assignment for := expressions.
Rosuav Apr 3, 2018
b075e91
Properly visit AssignExp nodes.
Rosuav Apr 8, 2018
e3ae6bb
Implement early binding of comprehension variables in class scope
Rosuav Apr 10, 2018
0142e99
Remove the special-casing of the outermost iterable in a comprehension
Rosuav Apr 11, 2018
cc2fc8c
Fix broken tests
Rosuav Apr 11, 2018
06a5f02
Add := to tokenizer
Rosuav Apr 13, 2018
9a6425b
Flag a name as early-bind only once
Rosuav Apr 13, 2018
94ab8ac
Remove now-superfluous helper function
Rosuav Apr 13, 2018
11e15cb
Perform the assertion mentioned in the comment
Rosuav Apr 17, 2018
2d153da
Adjust grammar to allow chaining
Rosuav Apr 17, 2018
dc88116
Change iteration variable name to avoid conflict
Rosuav Apr 17, 2018
225fe44
Remove test of implicit args now that there aren't any
Rosuav Apr 17, 2018
fdaef39
Regenerate autogeneratable files
Rosuav Apr 17, 2018
161aad8
Update disassembly tests to match current code
Rosuav Apr 17, 2018
41fedfa
Remove tests of outermost-iterable precomputation.
Rosuav Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove now-superfluous helper function
  • Loading branch information
@Rosuav
Rosuav committed Apr 17, 2018
commit 94ab8acaedb5c33d249ff7ed8cca11a2dec8e3e1
15 changes: 0 additions & 15 deletions 15 Python/symtable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ static int symtable_visit_keyword(struct symtable *st, keyword_ty);
static int symtable_visit_slice(struct symtable *st, slice_ty);
static int symtable_visit_params(struct symtable *st, asdl_seq *args);
static int symtable_visit_argannotations(struct symtable *st, asdl_seq *args);
static int symtable_implicit_arg(struct symtable *st, int pos);
static int symtable_visit_annotations(struct symtable *st, stmt_ty s, arguments_ty, expr_ty);
static int symtable_visit_withitem(struct symtable *st, withitem_ty item);

Expand Down Expand Up @@ -1523,20 +1522,6 @@ symtable_visit_expr(struct symtable *st, expr_ty e)
VISIT_QUIT(st, 1);
}

static int
symtable_implicit_arg(struct symtable *st, int pos)
{
PyObject *id = PyUnicode_FromFormat(".%d", pos);
if (id == NULL)
return 0;
if (!symtable_add_def(st, id, DEF_PARAM)) {
Py_DECREF(id);
return 0;
}
Py_DECREF(id);
return 1;
}

static int
symtable_visit_params(struct symtable *st, asdl_seq *args)
{
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.