Non-working attempt to introduce := as an assignment operator #6333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Apr 1, 2018
Grammar/Grammar
Outdated
| @@ -83,7 +83,7 @@ with_item: test ['as' expr] | ||
| except_clause: 'except' [test ['as' NAME]] | ||
| suite: simple_stmt | NEWLINE INDENT stmt+ DEDENT | ||
|
|
||
| test: or_test ['if' or_test 'else' test] | lambdef | ||
| test: [or_test ':='] or_test ['if' or_test 'else' test] | lambdef |
There was a problem hiding this comment.
Try or_test [':= or_test] instead.
8dcb966 to
22547d4
Compare
|
The test suite now passes except for those tests which specifically check for the specialness of the first iterable. |
28e0222 to
8886537
Compare
There's still stuff missing (eg this doesn't mark a name as local), but it's starting to look like what I want it to.
This appears to make them properly functional. I think.
8886537 to
161aad8
Compare
These tests would remain valid if genexp priming is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT FOR MERGING
This PR is just to make the branch more visible to maintainers, incl @gvanrossum