python · vstinner · Jun 16, 2017 · Jun 15, 2017 · serhiy-storchaka · Jun 16, 2017
diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py
@@ -438,6 +438,8 @@ def main(tests=None, testdir=None, verbose=0, quiet=False,

    if slaveargs is not None:
        args, kwargs = json.loads(slaveargs)
+        if kwargs['huntrleaks']:
+            warm_caches()
        if testdir:
            kwargs['testdir'] = testdir
        try:
@@ -448,6 +450,9 @@ def main(tests=None, testdir=None, verbose=0, quiet=False,
        print json.dumps(result)
        sys.exit(0)

+    if huntrleaks:
+        warm_caches()
+
    good = []
    bad = []
    skipped = []
@@ -1418,6 +1423,18 @@ def clear_caches():
    # Collect cyclic trash.
    gc.collect()

+def warm_caches():
+    """Create explicitly internal singletons which are created on demand
+    to prevent false positive when hunting reference leaks."""
+    # char cache
+    for i in range(256):
+        chr(i)
+    # unicode cache
+    for i in range(256):
+        unichr(i)
+    # int cache
+    list(range(-5, 257))
+
 def findtestdir(path=None):
    return path or os.path.dirname(__file__) or os.curdir
-Original file line number
+Diff line change
@@ -438,6 +438,8 @@ def main(tests=None, testdir=None, verbose=0, quiet=False,
         if slaveargs is not None:
             args, kwargs = json.loads(slaveargs)
         Comment thread


        

            
              Outdated
        
      

        
          


  
    
        
        
  
    
      
          
      

      
            serhiy-storchaka
  

      

      

      


        Jun 16, 2017



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Do you want to backport the slaveargs changes just backported to 3.5? Or there is no need?
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    


      



    
        
  
    
      
          
      

      
            vstinner
  

      

      

      


        Jun 16, 2017



      
    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

  Author


    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      I'm not interested to backport this change. While regrtest of 3.5 is old, regrtest of 2.7 is even older. Backporting regrtest enhancements is more and more complex :-/
If we want to get more new regrtest features, I would prefer to "simply" copy regrtest from master to other branches.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
+            if kwargs['huntrleaks']:
+                warm_caches()
             if testdir:
                 kwargs['testdir'] = testdir
             try:
@@ -448,6 +450,9 @@ def main(tests=None, testdir=None, verbose=0, quiet=False,
             print json.dumps(result)
             sys.exit(0)
+        if huntrleaks:
+            warm_caches()
         good = []
         bad = []
         skipped = []
@@ -1418,6 +1423,18 @@ def clear_caches():
         # Collect cyclic trash.
         gc.collect()
+    def warm_caches():
+        """Create explicitly internal singletons which are created on demand
+        to prevent false positive when hunting reference leaks."""
+        # char cache
+        for i in range(256):
+            chr(i)
+        # unicode cache
+        for i in range(256):
+            unichr(i)
+        # int cache
+        list(range(-5, 257))
     def findtestdir(path=None):
         return path or os.path.dirname(__file__) or os.curdir
-          Expand Down