Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.7] bpo-30675: Fix refleak hunting in regrtest#2227

Merged
vstinner merged 1 commit into
python:2.7python/cpython:2.7from
vstinner:regrtest_huntrefleak27Copy head branch name to clipboard
Jun 16, 2017
Merged

[2.7] bpo-30675: Fix refleak hunting in regrtest#2227
vstinner merged 1 commit into
python:2.7python/cpython:2.7from
vstinner:regrtest_huntrefleak27Copy head branch name to clipboard

Conversation

@vstinner

Copy link
Copy Markdown
Member

regrtest now warms up caches: create explicitly all internal
singletons which are created on demand to prevent false positives
when checking for reference leaks.

Comment thread Lib/test/regrtest.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to backport the slaveargs changes just backported to 3.5? Or there is no need?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not interested to backport this change. While regrtest of 3.5 is old, regrtest of 2.7 is even older. Backporting regrtest enhancements is more and more complex :-/

If we want to get more new regrtest features, I would prefer to "simply" copy regrtest from master to other branches.

Comment thread Lib/test/regrtest.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just -R. It can be used with other values.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed (-R 3:3).

regrtest now warms up caches: create explicitly all internal
singletons which are created on demand to prevent false positives
when checking for reference leaks.
@vstinner vstinner merged commit 8bb0863 into python:2.7 Jun 16, 2017
@vstinner vstinner deleted the regrtest_huntrefleak27 branch June 16, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.