Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-58319: IDLE: Add interrupt handle when open debugger#1821

Open
mlouielu wants to merge 8 commits into
python:mainpython/cpython:mainfrom
mlouielu:bpo-14111mlouielu/cpython:bpo-14111Copy head branch name to clipboard
Open

gh-58319: IDLE: Add interrupt handle when open debugger#1821
mlouielu wants to merge 8 commits into
python:mainpython/cpython:mainfrom
mlouielu:bpo-14111mlouielu/cpython:bpo-14111Copy head branch name to clipboard

Conversation

@mlouielu

@mlouielu mlouielu commented May 26, 2017

Copy link
Copy Markdown
Contributor

@mention-bot

Copy link
Copy Markdown

@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers.

@auvipy auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

@mlouielu mlouielu requested a review from terryjreedy as a code owner December 2, 2020 15:15
@roseman

roseman commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

I'm wondering about the naming of the function "user_interrupt".

The other "user_*" functions ("user_line", "user_exception", etc.) are Bdb callbacks that allow the debugger to update itself based on the current state of the running program. In this case, we're actually trying to control the running program, and this routine is called by our own code, not Bdb.

The Bdb "set_" functions do control the running program, so we could consider "set_interrupt". The only potential downside is that it wouldn't be clear that this isn't a Bdb function. Perhaps something along the lines of "force_interrupt"?

I'm not normally super-pendantic about names, but with all the difference places where code is running in the debugger, it's hard enough to follow as it is, so anything that can be done in IDLE to avoid confusion is a good thing.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 28, 2022
@terryjreedy

Copy link
Copy Markdown
Member

As with #15027, the merge conflict in run.py is because part of Executive.__init__ code was made conditional on not testing by #24302. I put the line added here, self.idb = None outside the condiition block as it should not interfere with other tests.

This PR also needs new tests.

@python python deleted a comment from bedevere-bot Nov 28, 2022
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 29, 2022
@hauntsaninja hauntsaninja changed the title bpo-14111: IDLE: Add interrupt handle when open debugger gh-58319: IDLE: Add interrupt handle when open debugger Jan 7, 2023
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 8, 2023
@arhadthedev arhadthedev added stdlib Standard Library Python modules in the Lib/ directory topic-IDLE labels Feb 4, 2023
@github-actions

github-actions Bot commented Mar 7, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time. stdlib Standard Library Python modules in the Lib/ directory topic-IDLE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Morty Proxy This is a proxified and sanitized view of the page, visit original site.