[3.8] Don't skip pickle check_frame_opcodes() (GH-15025)#15027
Merged
nascheme merged 1 commit intoJul 30, 2019
python:3.8python/cpython:3.8from
miss-islington:backport-eca7ffc-3.8miss-islington/cpython:backport-eca7ffc-3.8Copy head branch name to clipboard
Merged
[3.8] Don't skip pickle check_frame_opcodes() (GH-15025)#15027nascheme merged 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-eca7ffc-3.8miss-islington/cpython:backport-eca7ffc-3.8Copy head branch name to clipboard
nascheme merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-eca7ffc-3.8miss-islington/cpython:backport-eca7ffc-3.8Copy head branch name to clipboard
Conversation
This looks like the only place that proto 4 framing gets exercised so leave it as part of the PGO task. (cherry picked from commit eca7ffc) Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
Contributor
Author
|
@nascheme: Status check is done, and it's a success ✅ . |
3 similar comments
Contributor
Author
|
@nascheme: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@nascheme: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@nascheme: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like the only place that proto 4 framing gets exercised
so leave it as part of the PGO task.
(cherry picked from commit eca7ffc)
Co-authored-by: Neil Schemenauer nas-github@arctrix.com