Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.7] bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (GH-17652) (GH-17655)#17656

Merged
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-b0eb046-3.7miss-islington/cpython:backport-b0eb046-3.7Copy head branch name to clipboard
Dec 18, 2019
Merged

[3.7] bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (GH-17652) (GH-17655)#17656
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-b0eb046-3.7miss-islington/cpython:backport-b0eb046-3.7Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue38546

…ythonGH-17652) (pythonGH-17655)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b8bbdf0 into python:3.7 Dec 18, 2019
@miss-islington miss-islington deleted the backport-b0eb046-3.7 branch December 18, 2019 20:51
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.