Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (GH-17652)#17655

Merged
vstinner merged 1 commit into
python:3.8python/cpython:3.8from
vstinner:fix_test_futures38Copy head branch name to clipboard
Dec 18, 2019
Merged

[3.8] bpo-38546: Fix concurrent.futures test_ressources_gced_in_workers() (GH-17652)#17655
vstinner merged 1 commit into
python:3.8python/cpython:3.8from
vstinner:fix_test_futures38Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Dec 18, 2019

Copy link
Copy Markdown
Member

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)

https://bugs.python.org/issue38546

…H-17652)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Dec 18, 2019
@vstinner vstinner merged commit b0eb046 into python:3.8 Dec 18, 2019
@vstinner vstinner deleted the fix_test_futures38 branch December 18, 2019 20:30
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-17656 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2019
…ythonGH-17652) (pythonGH-17655)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Dec 18, 2019
…H-17652) (GH-17655)

Fix test_ressources_gced_in_workers() of test_concurrent_futures:
explicitly stop the manager to prevent leaking a child process
running in the background after the test completes.

(cherry picked from commit 673c393)
(cherry picked from commit b0eb046)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.