Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-38275: Fix test_ssl issue caused by GH-16386#16428

Merged
tiran merged 1 commit into
python:masterpython/cpython:masterfrom
tiran:bpo-38275-fixuptiran/cpython:bpo-38275-fixupCopy head branch name to clipboard
Sep 26, 2019
Merged

bpo-38275: Fix test_ssl issue caused by GH-16386#16428
tiran merged 1 commit into
python:masterpython/cpython:masterfrom
tiran:bpo-38275-fixuptiran/cpython:bpo-38275-fixupCopy head branch name to clipboard

Conversation

@tiran

@tiran tiran commented Sep 26, 2019

Copy link
Copy Markdown
Member

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38275

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
@vstinner

vstinner commented Sep 26, 2019

Copy link
Copy Markdown
Member

bpo-38275: Fix for GH-16386 #16428

Please mention at least test_ssl in the commit title when you merge this PR.

@tiran tiran changed the title bpo-38275: Fix for GH-16386 bpo-38275: Fix test_ssl issue caused by GH-16386 Sep 26, 2019
@tiran tiran merged commit 9f77268 into python:master Sep 26, 2019
@tiran tiran deleted the bpo-38275-fixup branch September 26, 2019 16:23
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.8

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9f77268f901cc3e8874e5042361520a0e482476a 3.7

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.