Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-38275: Skip ssl tests for disabled versions (GH-16386)#16425

Merged
tiran merged 2 commits into
python:3.8python/cpython:3.8from
tiran:backport-df6ac7e-3.8tiran/cpython:backport-df6ac7e-3.8Copy head branch name to clipboard
Sep 26, 2019
Merged

[3.8] bpo-38275: Skip ssl tests for disabled versions (GH-16386)#16425
tiran merged 2 commits into
python:3.8python/cpython:3.8from
tiran:backport-df6ac7e-3.8tiran/cpython:backport-df6ac7e-3.8Copy head branch name to clipboard

Conversation

@tiran

@tiran tiran commented Sep 26, 2019

Copy link
Copy Markdown
Member

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38275
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38275

test_ssl now handles disabled TLS/SSL versions better. OpenSSL's crypto
policy and run-time settings are recognized and tests for disabled versions
are skipped.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38275
(cherry picked from commit df6ac7e)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran

tiran commented Sep 26, 2019

Copy link
Copy Markdown
Member Author

PR needs fix from GH-16428

Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran

tiran commented Sep 26, 2019

Copy link
Copy Markdown
Member Author

I have cherry-picked commit 34992cf into this backport.

@tiran tiran merged commit 1931132 into python:3.8 Sep 26, 2019
@tiran tiran deleted the backport-df6ac7e-3.8 branch September 26, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.