Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-143959: Fix test_datetime if _datetime is unavailable#145248

Merged
serhiy-storchaka merged 1 commit into
python:mainpython/cpython:mainfrom
serhiy-storchaka:test_datetime-no-_datetimeserhiy-storchaka/cpython:test_datetime-no-_datetimeCopy head branch name to clipboard
Mar 22, 2026
Merged

gh-143959: Fix test_datetime if _datetime is unavailable#145248
serhiy-storchaka merged 1 commit into
python:mainpython/cpython:mainfrom
serhiy-storchaka:test_datetime-no-_datetimeserhiy-storchaka/cpython:test_datetime-no-_datetimeCopy head branch name to clipboard

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2026
Open
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 26, 2026
Closed
@serhiy-storchaka serhiy-storchaka force-pushed the test_datetime-no-_datetime branch from 6c63822 to 519b99e Compare February 26, 2026 10:27
@vstinner

vstinner commented Mar 2, 2026

Copy link
Copy Markdown
Member

I tested this change with this local patch:

diff --git a/Lib/test/test_datetime.py b/Lib/test/test_datetime.py
index 005187f13e6..013816e99b3 100644
--- a/Lib/test/test_datetime.py
+++ b/Lib/test/test_datetime.py
@@ -4,6 +4,7 @@
 
 from test.support.import_helper import import_fresh_module
 
+sys.modules['_datetime'] = None
 
 TESTS = 'test.datetimetester'

On the main branch, test_datetime fails with:

test test_datetime crashed -- Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/libregrtest/single.py", line 210, in _runtest_env_changed_exc
    _load_run_test(result, runtests)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/vstinner/python/main/Lib/test/libregrtest/single.py", line 165, in _load_run_test
    regrtest_runner(result, test_func, runtests)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vstinner/python/main/Lib/test/libregrtest/single.py", line 118, in regrtest_runner
    test_result = test_func()
  File "/home/vstinner/python/main/Lib/test/libregrtest/single.py", line 162, in test_func
    return run_unittest(test_mod, runtests)
  File "/home/vstinner/python/main/Lib/test/libregrtest/single.py", line 38, in run_unittest
    raise Exception("errors while loading tests")
Exception: errors while loading tests

With this PR, test_datetime pass.

vstinner
vstinner approved these changes Mar 2, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 97c725c into python:main Mar 22, 2026
49 checks passed
@miss-islington-app

miss-islington-app Bot commented Mar 22, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2026
@serhiy-storchaka @miss-islington
pythongh-143959: Fix test_datetime if _datetime is unavailable (pytho…
f67f73d 
…nGH-145248)

(cherry picked from commit 97c725c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2026
@serhiy-storchaka @miss-islington
pythongh-143959: Fix test_datetime if _datetime is unavailable (pytho…
23e190e 
…nGH-145248)

(cherry picked from commit 97c725c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Mar 22, 2026

Copy link
Copy Markdown

GH-146288 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 22, 2026
@bedevere-app

bedevere-app Bot commented Mar 22, 2026

Copy link
Copy Markdown

GH-146289 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 22, 2026
@serhiy-storchaka serhiy-storchaka deleted the test_datetime-no-_datetime branch March 22, 2026 14:16
@serhiy-storchaka

serhiy-storchaka commented Mar 22, 2026

Copy link
Copy Markdown
Member Author

Thank you @vstinner for your review and for your patch #143997 (comment) which I used to write and test these changes.

serhiy-storchaka added a commit that referenced this pull request Mar 22, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-143959: Fix test_datetime if _datetime is unavailable (GH-1…
0aa9153 
…45248) (GH-146289)

(cherry picked from commit 97c725c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 22, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-143959: Fix test_datetime if _datetime is unavailable (GH-1…
114d1c3 
…45248) (GH-146288)

(cherry picked from commit 97c725c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 23, 2026
@CuriousLearner
Merge branch 'main' of github.com:python/cpython into fix-pythongh-13…
3e05fa3 
…8577

* 'main' of github.com:python/cpython:
  pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)
  pythongh-146325: Use `test.support.requires_fork` in test_fastpath_cache_cleared_in_forked_child (python#146330)
  pythongh-146197: Add Emscripten to CI (python#146198)
  pythongh-143387: Raise an exception instead of returning None when metadata file is missing. (python#146234)
  pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)
  pythongh-146175: Soft-deprecate outdated macros; convert internal usage (pythonGH-146178)
  pythongh-146056: Rework ref counting in treebuilder_handle_end() (python#146167)
  Add a warning about untrusted input to `configparser` docs (python#146276)
  pythongh-145264: Do not ignore excess Base64 data after the first padded quad (pythonGH-145267)
  pythongh-146308: Fix error handling issues in _remote_debugging module (python#146309)
  pythongh-146192: Add base32 support to binascii (pythonGH-146193)
  pythongh-135953: Properly obtain main thread identifier in Gecko Collector (python#146045)
  pythongh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples (pythonGH-144300)
  pythongh-146261: Fix bug in `_Py_uop_sym_set_func_version` (pythonGH-146291)
  pythongh-145144: Add more tests for UserList, UserDict, etc (pythonGH-145145)
  pythongh-143959: Fix test_datetime if _datetime is unavailable (pythonGH-145248)
  pythongh-146245: Fix reference and buffer leaks via audit hook in socket module (pythonGH-146248)
  pythongh-140049: Colorize exception notes in `traceback.py` (python#140051)
  Update docs for pythongh-146056 (pythonGH-146213)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
pythongh-143959: Fix test_datetime if _datetime is unavailable (pytho…
dba0fc4 
…nGH-145248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @vstinner
Morty Proxy This is a proxified and sanitized view of the page, visit original site.