-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Add more tests for UserList, UserDict, etc #145144
Copy link
Copy link
Closed
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-featureA feature request or enhancementA feature request or enhancement
Description
Metadata
Metadata
Assignees
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-featureA feature request or enhancementA feature request or enhancement
Fields
Give feedbackNo fields configured for issues without a type.
It seems that some code in UserList, UserDict and UserString is not covered by tests. Some of existing tests are too lenient -- they tests the value of the result, but not its type. Some tests do not test particular combination of argument types. For some methods tests are absent at all. And some code is a pure optimization -- when remove it, the generic slower implementation is used. It is not always possible to test this.
The following PR adds more tests for UserList, UserDict and UserString. Some tests are added to generic tests, so new tests are also added for str, bytes, bytearray, list, tuple, deque, etc.
Linked PRs