Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-137562: Remove reference for GC_REACHABLE because it is obsolete#137563

Merged
methane merged 1 commit into
python:mainpython/cpython:mainfrom
sergey-miryanov:137562-fix-comments-subtract-refssergey-miryanov/cpython:137562-fix-comments-subtract-refsCopy head branch name to clipboard
Aug 9, 2025
Merged

gh-137562: Remove reference for GC_REACHABLE because it is obsolete#137563
methane merged 1 commit into
python:mainpython/cpython:mainfrom
sergey-miryanov:137562-fix-comments-subtract-refssergey-miryanov/cpython:137562-fix-comments-subtract-refsCopy head branch name to clipboard

Conversation

@sergey-miryanov

@sergey-miryanov sergey-miryanov commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

subtract_refs references an obsolete constant GC_REACHABLE

cpython/Python/gc.c

Lines 572 to 577 in 34d7351

/* Subtract internal references from gc_refs. After this, gc_refs is >= 0
* for all objects in containers, and is GC_REACHABLE for all tracked gc
* objects not in containers. The ones with gc_refs > 0 are directly
* reachable from outside containers, and so can't be collected.
*/
static void

It is obsolete since #7043

@sergey-miryanov

Copy link
Copy Markdown
Contributor Author

I believe this should skip news.

@sergey-miryanov

Copy link
Copy Markdown
Contributor Author

@methane @nascheme Please take a look.

@methane methane merged commit c744b57 into python:main Aug 9, 2025
44 checks passed
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.