Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix obsolete comments in gc.c #137562

Copy link
Copy link

Description

@sergey-miryanov
Issue body actions

1

gc.c/subtract_refs references an obsolete constant GC_REACHABLE

cpython/Python/gc.c

Lines 572 to 577 in 34d7351

/* Subtract internal references from gc_refs. After this, gc_refs is >= 0
* for all objects in containers, and is GC_REACHABLE for all tracked gc
* objects not in containers. The ones with gc_refs > 0 are directly
* reachable from outside containers, and so can't be collected.
*/
static void

It is obsolete since #7043

2

gc.c/SCAN_RATE_DIVISOR has obsolete comment about calculating incremental threshold based on count of survivors. It is obsolete since #117120

cpython/Python/gc.c

Lines 1345 to 1362 in 34d7351

/* Making progress in the incremental collector
* In order to eventually collect all cycles
* the incremental collector must progress through the old
* space faster than objects are added to the old space.
*
* Each young or incremental collection adds a number of
* objects, S (for survivors) to the old space, and
* incremental collectors scan I objects from the old space.
* I > S must be true. We also want I > S * N to be where
* N > 1. Higher values of N mean that the old space is
* scanned more rapidly.
* The default incremental threshold of 10 translates to
* N == 1.4 (1 + 4/threshold)
*/
/* Divide by 10, so that the default incremental threshold of 10
* scans objects at 1% of the heap size */
#define SCAN_RATE_DIVISOR 10

3

Reference #135552 instead of #91636 when writing about deallocated objects in the type cache.

Linked PRs

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation in the Doc dirDocumentation in the Doc dirinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
    No fields configured for issues without a type.

    Projects

    Status
    Todo
    Show more project fields

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.