Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-98822: Add missing test directories to TESTSUBDIRS#103942

Merged
erlend-aasland merged 2 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:testsubdirserlend-aasland/cpython:testsubdirsCopy head branch name to clipboard
Apr 27, 2023
Merged

gh-98822: Add missing test directories to TESTSUBDIRS#103942
erlend-aasland merged 2 commits into
python:mainpython/cpython:mainfrom
erlend-aasland:testsubdirserlend-aasland/cpython:testsubdirsCopy head branch name to clipboard

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from zware April 27, 2023 19:09
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 27, 2023

Simply the sorted output of find Lib/test -type d.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 27, 2023

BTW, obviously needs a manual backport.

@erlend-aasland erlend-aasland merged commit bf0b8a9 into python:main Apr 27, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 27, 2023

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 27, 2023

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker bf0b8a9f8d647515170cbdf3b6a8c0f44e0f37b3 3.11

@erlend-aasland erlend-aasland deleted the testsubdirs branch April 27, 2023 19:43
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 27, 2023

Thanks for the review, Zach.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 27, 2023

Oh, I merged before the macOS CI was finished; sorry 'bout that!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 27, 2023

GH-103946 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 27, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Apr 27, 2023
@erlend-aasland
[3.11] pythongh-98822: Add missing test directories to TESTSUBDIRS (p…
46a2fea 
…ython#103942)
erlend-aasland added a commit that referenced this pull request Apr 27, 2023
@erlend-aasland
[3.11] gh-98822: Add missing test directories to TESTSUBDIRS (#103942) (
838bc90 
#103946)
@asottile
Copy link
Copy Markdown
Contributor

asottile commented Apr 28, 2023

this shouldn't have been backported verbatim to 3.11 -- the subdirs added there are incorrect (for example the tkinter ones)

@zware
Copy link
Copy Markdown
Member

zware commented Apr 28, 2023

Ah, whoops; we did miss some differences. See GH-103970.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 28, 2023

this shouldn't have been backported verbatim to 3.11 -- the subdirs added there are incorrect (for example the tkinter ones)

It wasn't backported verbatim at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @bedevere-bot @asottile @zware
Morty Proxy This is a proxified and sanitized view of the page, visit original site.