Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.11] gh-98822: Add missing test directories to TESTSUBDIRS (#103942)#103946

Merged
erlend-aasland merged 1 commit into
python:3.11python/cpython:3.11from
erlend-aasland:3.11-testsubdirserlend-aasland/cpython:3.11-testsubdirsCopy head branch name to clipboard
Apr 27, 2023
Merged

[3.11] gh-98822: Add missing test directories to TESTSUBDIRS (#103942)#103946
erlend-aasland merged 1 commit into
python:3.11python/cpython:3.11from
erlend-aasland:3.11-testsubdirserlend-aasland/cpython:3.11-testsubdirsCopy head branch name to clipboard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Zach. I trust the CI to wait for the macOS check 🤖 😄

@zware

zware commented Apr 27, 2023

Copy link
Copy Markdown
Member

I'm not sure it will: apparently macOS isn't required on main :)

Edit: but it is on 3.11, so that's irrelevant here 🤦‍♂️. Automerge should in fact wait here, but probably (not sure we've tested it yet?) wouldn't have in the main PR.

@erlend-aasland erlend-aasland merged commit 838bc90 into python:3.11 Apr 27, 2023
@erlend-aasland erlend-aasland deleted the 3.11-testsubdirs branch April 27, 2023 20:35
@ned-deily

ned-deily commented Apr 27, 2023

Copy link
Copy Markdown
Member

I will explicitly test this on both main and 3.11 on macOS. I just noticed on Tuesday at the sprint just before I left that no sqlite tests seemed to be running when using an installed Python and was going to investigate that next; I suspected it would turn out to be something like this.

zware added a commit to zware/cpython that referenced this pull request Apr 28, 2023
A few differences from the main branch were missed in pythonGH-103946.
zware added a commit that referenced this pull request Apr 28, 2023
A few differences from the main branch were missed in GH-103946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.