[3.11] gh-101845: pyspecific: Fix i18n for availability directive (GH-101846)#101852
Merged
miss-islington merged 1 commit intoFeb 12, 2023
python:3.11python/cpython:3.11from
miss-islington:backport-6ef6915-3.11miss-islington/cpython:backport-6ef6915-3.11Copy head branch name to clipboard
Merged
[3.11] gh-101845: pyspecific: Fix i18n for availability directive (GH-101846)#101852miss-islington merged 1 commit intopython:3.11python/cpython:3.11from miss-islington:backport-6ef6915-3.11miss-islington/cpython:backport-6ef6915-3.11Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.11python/cpython:3.11from
miss-islington:backport-6ef6915-3.11miss-islington/cpython:backport-6ef6915-3.11Copy head branch name to clipboard
Conversation
…honGH-101846) pyspecific: Fix i18n for availability directive If the directive has content, the previous code would nest paragraph nodes from that content inside a general paragraph node, which confuses Sphinx and leads it to drop the content when translating. Instead, use a container node for the body. Also use set_source_info so that any warnings have location info. (cherry picked from commit 6ef6915) Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
This was referenced Feb 12, 2023
JulienPalard
approved these changes
Feb 12, 2023
JulienPalard
added a commit
to python/python-docs-fr
that referenced
this pull request
Feb 12, 2023
Pour python/cpython#101852 Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/34 Co-authored-by: Julien Palard <julien@palard.fr> Co-committed-by: Julien Palard <julien@palard.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyspecific: Fix i18n for availability directive
If the directive has content, the previous code would nest paragraph
nodes from that content inside a general paragraph node, which confuses
Sphinx and leads it to drop the content when translating. Instead, use a
container node for the body.
Also use set_source_info so that any warnings have location info.
(cherry picked from commit 6ef6915)
Co-authored-by: Jean Abou-Samra jean@abou-samra.fr