PhpUnit with junit runs more stable#160
Closed
SimonHeimberg wants to merge 4 commits into
php-censor:masterphp-censor/php-censor:masterfrom
SimonHeimberg:phpUnitJunitMoreStableSimonHeimberg/php-censor:phpUnitJunitMoreStableCopy head branch name to clipboard
Closed
PhpUnit with junit runs more stable#160SimonHeimberg wants to merge 4 commits intophp-censor:masterphp-censor/php-censor:masterfrom SimonHeimberg:phpUnitJunitMoreStableSimonHeimberg/php-censor:phpUnitJunitMoreStableCopy head branch name to clipboard
SimonHeimberg wants to merge 4 commits into
php-censor:masterphp-censor/php-censor:masterfrom
SimonHeimberg:phpUnitJunitMoreStableSimonHeimberg/php-censor:phpUnitJunitMoreStableCopy head branch name to clipboard
Conversation
Work around outup from phpunit versions before 6.5.7/7.0.2 (before sebastianbergmann/phpunit#2974 was fixed).
Contributor
Author
|
a test case is in preparation |
| $suites = null; | ||
| } | ||
| if (!$suites) { | ||
| // from https://stackoverflow.com/questions/7766455/how-to-handle-invalid-unicode-with-simplexml/8092672#8092672 |
Member
There was a problem hiding this comment.
PHPCS: Line exceeds 120 characters; contains 124 characters
| return $suites; | ||
| } | ||
|
|
||
| private function internalProblem($description) |
Member
There was a problem hiding this comment.
PHPCensor\Plugin\Util\PhpUnitResultJunit::internalProblem::PHPCensor\Plugin\Util\PhpUnitResultJunit::internalProblem is missing a docblock.
| return $suites; | ||
| } | ||
|
|
||
| private function internalProblem($description) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\Util\PhpUnitResultJunit::internalProblem is missing a docblock.
Member
|
@SimonHeimberg Great work, thank you! I will wait for the test cases. |
Member
|
@SimonHeimberg Any news? |
Contributor
|
Conflicts? |
Member
|
@SimonHeimberg I merged this pull request to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution type
bug fix / workaround
Description of change
PhpUnit Plugin works with result in junit format containing invalid characters.