feature: check localization command#174
Merged
corpsee merged 3 commits intoMay 1, 2018
php-censor:masterphp-censor/php-censor:masterfrom
caouecs:check_localizationsCopy head branch name to clipboard
Merged
feature: check localization command#174corpsee merged 3 commits intophp-censor:masterphp-censor/php-censor:masterfrom caouecs:check_localizationsCopy head branch name to clipboard
corpsee merged 3 commits into
php-censor:masterphp-censor/php-censor:masterfrom
caouecs:check_localizationsCopy head branch name to clipboard
Conversation
| $this->add(new CheckLocalizationCommand()); | ||
| } | ||
|
|
||
| public function getHelp() |
Member
There was a problem hiding this comment.
PHPCensor\Console\Application::getHelp::PHPCensor\Console\Application::getHelp is missing a docblock.
Closed
| /** | ||
| * Loops through running. | ||
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) |
Member
There was a problem hiding this comment.
Class PHPCensor\Command\CheckLocalizationCommand::execute is missing a docblock.
| /** | ||
| * Loops through running. | ||
| */ | ||
| protected function execute(InputInterface $input, OutputInterface $output) |
Member
There was a problem hiding this comment.
Class PHPCensor\Command\CheckLocalizationCommand::execute is missing a docblock.
Member
|
@caouecs Thank you! I will try to test and merge the request today. Very useful command 👍 |
corpsee
reviewed
May 1, 2018
| $output->writeln('<info>Check localizations!</info>'); | ||
| $output->writeln(''); | ||
|
|
||
| $sameThanEnglish = (isset($input->getOption('same'))) ? $input->getOption('same') : false; |
Member
There was a problem hiding this comment.
PHP Fatal error: Cannot use isset() on the result of a function call (you can use "null !== func()" instead) in /home/travis/build/php-censor/php-censor/src/Command/CheckLocalizationCommand.php on line 63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution type
new feature on resources
Description of change
A command to check localization files, with English version :
You can choose languages list (separated by commas) with "lang" option :
If you need tags with same translations than English version, vous can choose the "same" option :
And you can combine options :