[RFC] SQLite3: remove enableExceptions method, default to exceptions#9816
Closed
bohwaz wants to merge 1 commit into
Closed
[RFC] SQLite3: remove enableExceptions method, default to exceptions#9816bohwaz wants to merge 1 commit into
bohwaz wants to merge 1 commit into
Conversation
Contributor
Author
|
Replaced by #11058 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, the enableExceptions method is removed, and all errors are thrown as
SQLite3Exception.Also, the error code is passed as the exception code, and not in the error message anymore.
BC-break: yes.
RFC: https://wiki.php.net/rfc/sqlite3_exceptions