[RFC] Transition SQLite3 to exceptions#11058
Merged
Girgias merged 8 commits intoJul 3, 2023
php:masterphp/php-src:masterfrom
bohwaz:sqlite3/exceptions-8.3bohwaz/php-src:sqlite3/exceptions-8.3Copy head branch name to clipboard
Merged
[RFC] Transition SQLite3 to exceptions#11058Girgias merged 8 commits intophp:masterphp/php-src:masterfrom bohwaz:sqlite3/exceptions-8.3bohwaz/php-src:sqlite3/exceptions-8.3Copy head branch name to clipboard
Girgias merged 8 commits into
php:masterphp/php-src:masterfrom
bohwaz:sqlite3/exceptions-8.3bohwaz/php-src:sqlite3/exceptions-8.3Copy head branch name to clipboard
Conversation
Girgias
reviewed
Apr 11, 2023
TimWolla
reviewed
Apr 13, 2023
Contributor
Author
|
The RFC was accepted 21 to zero. |
Girgias
approved these changes
May 25, 2023
Member
Girgias
left a comment
There was a problem hiding this comment.
Could you update the UPGRADING file with a relevant entry
Contributor
Author
|
Can we get this merged for PHP 8.3? Thanks :) |
Member
|
Would you mind rebasing your branch please ? It ll be merged in due time no worries :) |
Contributor
Author
|
I'm sorry but git is bringing thousands of unrelated changes when doing "git rebase -i", don't you have a github button to do that? |
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
066dd7d to
4973ca3
Compare
Member
|
@bohwaz Can you just double check that I rebased the branch correctly? |
Contributor
Author
|
Thank you very much, I don't see any issue so far. |
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Oct 11, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 18, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, exceptions are thrown using the SQLite3Exception class, and enabling warnings is deprecated.
Also, the error code is passed as the exception code, and not in the error message anymore.
BC-break: yes.
RFC: https://wiki.php.net/rfc/sqlite3_exceptions