Cleanup tests version checks#2209
Closed
tvlooy wants to merge 3 commits into
php:masterphp/php-src:masterfrom
tvlooy:cleanup_tests_versionchecktvlooy/php-src:cleanup_tests_versioncheckCopy head branch name to clipboard
Closed
Cleanup tests version checks#2209tvlooy wants to merge 3 commits intophp:masterphp/php-src:masterfrom tvlooy:cleanup_tests_versionchecktvlooy/php-src:cleanup_tests_versioncheckCopy head branch name to clipboard
tvlooy wants to merge 3 commits into
php:masterphp/php-src:masterfrom
tvlooy:cleanup_tests_versionchecktvlooy/php-src:cleanup_tests_versioncheckCopy head branch name to clipboard
Conversation
|
Comment on behalf of krakjoe at php.net: Labelling |
Member
|
Could I ask that you annotate the patch where files have been deleted with a specific reason (that I or someone else can verify is correct), please ? |
Contributor
Author
|
About the removed files: These are tests that are skipped if the PHP version is not 6.0, so they are never run: This is a check to make sure the test is skipped with PHP version 6.0. So it is always run: These are tests that are skipped if the PHP version is not lower or equal to 5.2 or 5.3, so they are never run: Do you want me to put a comment in the diff for each of these files pointing to the line with the check? I'm not sure what you mean by annotating the diff. |
krakjoe
reviewed
Nov 20, 2016
| magic_quotes_gpc=1 | ||
| --SKIPIF-- | ||
| <?php if (version_compare(PHP_VERSION, "5.3", "<")) die("skip requires 5.3 or greater"); ?> | ||
| --FILE-- |
Member
|
Looks fine, other than couple of failures on travis that I think shouldn't be there. |
nikic
reviewed
Nov 20, 2016
| if (!extension_loaded("phar")) die("skip"); | ||
| if (!extension_loaded("spl")) die("skip SPL not available"); | ||
| if (version_compare(PHP_VERSION, "5.3", "<") or version_compare(PHP_VERSION, "5.4", ">=")) | ||
| die("skip requires 5.3"); |
Member
There was a problem hiding this comment.
I wonder why PHP >= 5.4 was excluded in this test.
nikic
approved these changes
Nov 20, 2016
Member
|
Merged via 442fd2f. Thanks! |
Closed
tvlooy
commented
Nov 22, 2016
| } | ||
|
|
||
| if (!(version_compare(PHP_VERSION, '6.0', '==') == 1)) { | ||
| mysqli_query($link, "set names utf8"); |
tvlooy
commented
Nov 22, 2016
|
|
||
| /* we need to skip this test in unicode - we send set names utf8 during mysql_connect */ | ||
| if (!(version_compare(PHP_VERSION, '6.0', '==') == 1)) | ||
| mysqli_get_client_stats_assert_eq('non_result_set_queries', $new_info, $info, $test_counter); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is clean-up. Remove all useless version checks from extension tests and remove some code or entire tests that are not valid any more.