Remove binary prefix and cast from unrelated tests#2194
Closed
pmmaga wants to merge 2 commits into
php:masterphp/php-src:masterfrom
pmmaga:remove-binary-unrelated-testspmmaga/php-src:remove-binary-unrelated-testsCopy head branch name to clipboard
Closed
Remove binary prefix and cast from unrelated tests#2194pmmaga wants to merge 2 commits intophp:masterphp/php-src:masterfrom pmmaga:remove-binary-unrelated-testspmmaga/php-src:remove-binary-unrelated-testsCopy head branch name to clipboard
pmmaga wants to merge 2 commits into
php:masterphp/php-src:masterfrom
pmmaga:remove-binary-unrelated-testspmmaga/php-src:remove-binary-unrelated-testsCopy head branch name to clipboard
Conversation
|
Comment on behalf of krakjoe at php.net: adding label |
Contributor
Author
|
The failing test on Travis is unrelated to this changes |
Member
|
Merge of #2209 caused some conflicts. Can you please rebase this PR? |
bfba8f6 to
bb76bc9
Compare
bb76bc9 to
524943f
Compare
nikic
approved these changes
Nov 20, 2016
Member
Member
|
Any reason why this has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a child PR from #2187, this aims only at removing the binary prefix and cast from tests that are not directly related to binary string handling.