Fix header errors when parsed standalone#14272
Fix header errors when parsed standalone#14272
Conversation
dstogov
left a comment
There was a problem hiding this comment.
I don't see anything bad.
I'm not sure why do you need a separate header for zend_result...
This is annoying for multiple reasons: 1. LSPs can show many errors for these files. 2. LSP can stop parsing these files completely if there are too many errors, resulting in spotty LSP features.
8bd45c3 to
5edc5e5
Compare
It reduced a few imports of |
TimWolla
left a comment
There was a problem hiding this comment.
I'm in favor, but would like to point out this RFC: https://wiki.php.net/rfc/include_cleanup and this PR: #10609.
I believe there should be a more systematic approach than just making a few changes here and there when one notices the issues.
|
I'm aware of the RFC, but since it was declined, it doesn't seem sincere to make the same changes again. Another proposal might be more successful now, with less drama. |
|
This PR adds forward declarations which was an idea I proposed in https://wiki.php.net/rfc/include_cleanup but was rejected by the majority of PHP developers, including @dstogov - now I wonder why he agreed with this PR ... ? |
This is annoying for multiple reasons:
On my machine, two debug build without ccache took 55s/56s for
master, and 56s/56s for this branch, so it does not seem like it changed significantly.