Zend/zend_types.h: move zend_result to separate header#10609
Merged
Merged
Zend/zend_types.h: move zend_result to separate header#10609
zend_result to separate header#10609Conversation
Many sources need just `zend_result`, and with this new header, they only need to include `zend_result.h` instead of `zend_types.h`; the latter is large and has fat dependencies, which slows down the build.
This was referenced Feb 21, 2023
Merged
dstogov
added a commit
that referenced
this pull request
Apr 4, 2023
)" This reverts commit 3bce116.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many sources need just
zend_result, and with this new header, they only need to includezend_result.hinstead ofzend_types.h; the latter is large and has fat dependencies, which slows down the build.(This implements the vote "Is it allowed to split a large header to reduce dependencies?" which was accepted by a supermajority, see https://wiki.php.net/rfc/include_cleanup)