fs: extend signal option to lstat, fstat and promises API#63143
Open
mertcanaltin wants to merge 10 commits into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/fs-stat-paritymertcanaltin/node:mert/fs-stat-parityCopy head branch name to clipboard
Open
fs: extend signal option to lstat, fstat and promises API#63143mertcanaltin wants to merge 10 commits intonodejs:mainnodejs/node:mainfrom mertcanaltin:mert/fs-stat-paritymertcanaltin/node:mert/fs-stat-parityCopy head branch name to clipboard
mertcanaltin wants to merge 10 commits into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/fs-stat-paritymertcanaltin/node:mert/fs-stat-parityCopy head branch name to clipboard
Conversation
b700b01 to
face7e9
Compare
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
face7e9 to
d310519
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63143 +/- ##
==========================================
+ Coverage 90.03% 90.34% +0.30%
==========================================
Files 713 730 +17
Lines 224699 234433 +9734
Branches 42473 43960 +1487
==========================================
+ Hits 202310 211798 +9488
- Misses 14179 14387 +208
- Partials 8210 8248 +38
🚀 New features to boost your workflow:
|
atlowChemi
reviewed
May 24, 2026
atlowChemi
reviewed
May 24, 2026
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
Add validateObject before reading options.signal in the promises stat, lstat and fstat, matching the rest of the module. Import the PromiseWithResolvers primordial and drop the now-unused kResistStopPropagation left over from the raceWithSignal rewrite.
atlowChemi
approved these changes
May 24, 2026
jasnell
reviewed
May 25, 2026
Co-authored-by: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #63142. Adds AbortSignal support to
fs.lstat,fs.fstat,fsPromises.stat,fsPromises.lstat,fsPromises.fstatandfilehandle.statto matchfs.stat. Addresses @LiviaMedeiros's parity request from #57775.Will rebase once #63142 lands.
Refs: #57775