fs: abort in-flight stat operations#63142
Open
mertcanaltin wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/fs-stat-inflight-fixmertcanaltin/node:mert/fs-stat-inflight-fixCopy head branch name to clipboard
Open
fs: abort in-flight stat operations#63142mertcanaltin wants to merge 1 commit intonodejs:mainnodejs/node:mainfrom mertcanaltin:mert/fs-stat-inflight-fixmertcanaltin/node:mert/fs-stat-inflight-fixCopy head branch name to clipboard
mertcanaltin wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/fs-stat-inflight-fixmertcanaltin/node:mert/fs-stat-inflight-fixCopy head branch name to clipboard
Conversation
4425502 to
e4d317e
Compare
Contributor
|
Drive-by: this looks like it's still not actually canceling the underlying call, which would involve invoking |
e4d317e to
8149c79
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63142 +/- ##
========================================
Coverage 90.03% 90.03%
========================================
Files 713 713
Lines 224699 224978 +279
Branches 42473 42541 +68
========================================
+ Hits 202310 202563 +253
- Misses 14179 14183 +4
- Partials 8210 8232 +22
🚀 New features to boost your workflow:
|
8149c79 to
fc73958
Compare
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
fc73958 to
6d3d629
Compare
Member
Author
|
Thanks for review @bakkot I added a new binding function for cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #57775. The signal option only honored the pre-aborted case (#57775 (comment) by @Renegade334). This wires the signal as an abort listener so
fs.statcallbacks reject withAbortErrorwhen the signal fires mid-request.Refs: #57775