[v12.x] http2: update handling of streams on rst_stream frames#39659
[v12.x] http2: update handling of streams on rst_stream frames#39659kumarak wants to merge 2 commits intonodejs:v12.x-stagingnodejs/node:v12.x-stagingfrom kumarak:kumarak/v12.x_backport_rst_streamkumarak/node:kumarak/v12.x_backport_rst_streamCopy head branch name to clipboard
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Should I expect the testcase to fail on earlier versions of Node.js 12? When I test locally with 12.22.4 and without the http2 change in this PR the testcase passes. |
|
@richardlau, Ideally the test should verify the fixes but I was unable to reproduce the issue without So I simplified the test case and only checks the RST_STREAM frames getting sent with cancel error code, the stream is in the paused-reading state, and there is no issue with handling it(e.g: no endpoint hang, no stream close error). The behavior is same what it was previously and the test case passes with the older version as well. |
|
This went out in 12.22.5 in f2f7a45...9cd1f53. |
Backport ref PR #39622 and resolve merge conflict with
git cherry-pick