http2: update handling of streams on rst_stream frames#39622
Closed
kumarak wants to merge 2 commits into
nodejs:masternodejs/node:masterfrom
kumarak:kumarak/handling_rst_streamkumarak/node:kumarak/handling_rst_streamCopy head branch name to clipboard
Closed
http2: update handling of streams on rst_stream frames#39622kumarak wants to merge 2 commits intonodejs:masternodejs/node:masterfrom kumarak:kumarak/handling_rst_streamkumarak/node:kumarak/handling_rst_streamCopy head branch name to clipboard
kumarak wants to merge 2 commits into
nodejs:masternodejs/node:masterfrom
kumarak:kumarak/handling_rst_streamkumarak/node:kumarak/handling_rst_streamCopy head branch name to clipboard
Conversation
74bdd33 to
9e6745c
Compare
mcollina
approved these changes
Aug 3, 2021
mcollina
left a comment
Member
There was a problem hiding this comment.
lgtm
Could you add a test for the other cases?
jasnell
approved these changes
Aug 3, 2021
BethGriggs
approved these changes
Aug 3, 2021
Contributor
Author
|
Thanks, @mcollina! I will add tests for specific cases. |
Collaborator
Member
Contributor
Author
|
@BethGriggs, The changes should not need to backport for v12.x. I will verify and raise a PR with v12.x if needed. |
701ef63 to
9b39a6b
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
BethGriggs
pushed a commit
that referenced
this pull request
Aug 6, 2021
The PR updates the handling of rst_stream frames and adds all streams to the pending list on receiving rst frames with the error code NGHTTP2_CANCEL. The changes will remove dependency on the stream state that may allow bypassing the checks in certain cases. I think a better solution is to delay streams in all cases if rst_stream is received for the cancel events. The rst_stream frames can be received for protocol/connection error as well it should be handled immediately. Adding streams to the pending list in such cases may cause errors. PR-URL: #39622 Refs: #39423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Member
|
Landed in c7a0f1d...b00d1ae |
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
The PR updates the handling of rst_stream frames and adds all streams to the pending list on receiving rst frames with the error code NGHTTP2_CANCEL. The changes will remove dependency on the stream state that may allow bypassing the checks in certain cases. I think a better solution is to delay streams in all cases if rst_stream is received for the cancel events. The rst_stream frames can be received for protocol/connection error as well it should be handled immediately. Adding streams to the pending list in such cases may cause errors. CVE-ID: CVE-2021-22930 Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22930 PR-URL: nodejs#39622 Refs: nodejs#39423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#39622 Refs: nodejs#39423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR updates the handling of rst_stream frames and add
all streams to the pending list on receiving rst frames with
the error code
NGHTTP2_CANCEL.The changes will remove dependency on the stream state
that may allow bypassing the checks in certain cases. I think
a better solution is to delay streams in all cases if rst_stream
is received for the cancel events.
The rst_stream frames can be received for protocol/connection
error as well it should be handled immediately. Adding
streams to the pending list in such cases may cause errors.
Previous PR ref: #39423