[23.0 backport] builder: define GetRemotes for the worker#44944
Merged
neersighted merged 1 commit intoFeb 8, 2023
moby:23.0moby/moby:23.0from
thaJeztah:23.0_backport_worker_getremotesthaJeztah/docker:23.0_backport_worker_getremotesCopy head branch name to clipboard
Merged
[23.0 backport] builder: define GetRemotes for the worker#44944neersighted merged 1 commit intomoby:23.0moby/moby:23.0from thaJeztah:23.0_backport_worker_getremotesthaJeztah/docker:23.0_backport_worker_getremotesCopy head branch name to clipboard
neersighted merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_backport_worker_getremotesthaJeztah/docker:23.0_backport_worker_getremotesCopy head branch name to clipboard
Conversation
Member
Author
|
Kept this in draft for now, pending #44920 (comment) (in case we want to fix the commit message) |
Member
Author
|
Failure on Windows-2022 https://github.com/moby/moby/actions/runs/4114098814/jobs/7101259444 in |
thaJeztah
force-pushed
the
23.0_backport_worker_getremotes
branch
from
February 7, 2023 22:44
a5c1351 to
135d6c3
Compare
Member
Author
The function signature has changed since v0.10. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 335907d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
23.0_backport_worker_getremotes
branch
from
February 8, 2023 00:01
135d6c3 to
e697c93
Compare
thaJeztah
marked this pull request as ready for review
February 8, 2023 00:03
Member
Author
|
Rebased; this should be ready for review ./cc @neersighted @tonistiigi |
tonistiigi
approved these changes
Feb 8, 2023
neersighted
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function signature has changed since v0.10.
(cherry picked from commit 335907d)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)