Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[23.0] vendor: github.com/moby/buildkit v0.10.7-0.20230206124303-b8fdb4b78da0#44936

Merged
thaJeztah merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_update_buildkitthaJeztah/docker:23.0_update_buildkitCopy head branch name to clipboard
Feb 7, 2023
Merged

[23.0] vendor: github.com/moby/buildkit v0.10.7-0.20230206124303-b8fdb4b78da0#44936
thaJeztah merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_update_buildkitthaJeztah/docker:23.0_update_buildkitCopy head branch name to clipboard

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Feb 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

full diff: moby/buildkit@v0.10.6...b8fdb4b

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 23.0.1 milestone Feb 6, 2023
thaJeztah
thaJeztah commented Feb 6, 2023
View reviewed changes
Comment thread vendor.mod
github.com/miekg/dns v1.1.43
github.com/mistifyio/go-zfs v2.1.2-0.20190413222219-f784269be439+incompatible
github.com/moby/buildkit v0.10.6
github.com/moby/buildkit v0.10.7-0.20230206124303-b8fdb4b78da0

@thaJeztah thaJeztah Feb 6, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi do you know if there were other issues for v0.10.x and/or if there were plans for tagging a new version?

@thaJeztah
[23.0] vendor: github.com/moby/buildkit v0.10.7-0.20230206124303-b8fd…
8a5d341 
…b4b78da0

full diff: moby/buildkit@v0.10.6...b8fdb4b

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah force-pushed the 23.0_update_buildkit branch from 1148c5e to 8a5d341 Compare February 7, 2023 08:55
@thaJeztah

thaJeztah commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Interesting; looks like checkout actions also sets the "safe" option now (or did it already?);

Run actions/checkout@v3
Syncing repository: moby/moby
Getting Git version info
  Working directory is 'D:\a\moby\moby\go\src\github.com\docker\docker'
  "C:\Program Files\Git\bin\git.exe" version
  git version 2.39.1.windows.1
Temporarily overriding HOME='D:\a\_temp\216a9447-39cb-41e2-aadd-0d226ca582d6' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\moby\moby\go\src\github.com\docker\docker

Looks like we're hitting rate limits now on GitHub though;

Fetching the repository
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +f599f60c9ecf5531eb90cd893b78d09d0b13e8b6:refs/remotes/pull/44936/merge
  Error: fatal: unable to access 'https://github.com/moby/moby/': The requested URL returned error: 429
  The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128
  Waiting 16 seconds before trying again
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +f599f60c9ecf5531eb90cd893b78d09d0b13e8b6:refs/remotes/pull/44936/merge
  Error: fatal: unable to access 'https://github.com/moby/moby/': The requested URL returned error: 429
  The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128
  Waiting 18 seconds before trying again
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +f599f60c9ecf5531eb90cd893b78d09d0b13e8b6:refs/remotes/pull/44936/merge
  Error: fatal: unable to access 'https://github.com/moby/moby/': The requested URL returned error: 429
  Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128

@thaJeztah

thaJeztah commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Green now; bringing this one in

@thaJeztah
thaJeztah merged commit a25ab92 into moby:23.0 Feb 7, 2023
@thaJeztah
thaJeztah deleted the 23.0_update_buildkit branch February 7, 2023 10:29
@thaJeztah thaJeztah mentioned this pull request Feb 7, 2023
Merged
@neersighted

neersighted commented Feb 7, 2023

Copy link
Copy Markdown
Member

The checkout action has set the safe.directory option for some time; we only run into this issue when we're in a container, which has a different gitconfig.

@thaJeztah

thaJeztah commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Yeah, I was wondering if it was something recent (and potentially for the same reason we now also had to set it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neersighted neersighted neersighted approved these changes

Assignees

No one assigned

Labels

area/builder/buildkit Build kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Milestone

23.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @neersighted
Morty Proxy This is a proxified and sanitized view of the page, visit original site.