[23.0 backport] Fix volume CreatedAt being altered on initialization#44725
Merged
thaJeztah merged 1 commit intoJan 3, 2023
moby:23.0moby/moby:23.0from
thaJeztah:23.0_backport_fix_volume_createdatthaJeztah/docker:23.0_backport_fix_volume_createdatCopy head branch name to clipboard
Merged
[23.0 backport] Fix volume CreatedAt being altered on initialization#44725thaJeztah merged 1 commit intomoby:23.0moby/moby:23.0from thaJeztah:23.0_backport_fix_volume_createdatthaJeztah/docker:23.0_backport_fix_volume_createdatCopy head branch name to clipboard
thaJeztah merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_backport_fix_volume_createdatthaJeztah/docker:23.0_backport_fix_volume_createdatCopy head branch name to clipboard
Conversation
neersighted
marked this pull request as draft
January 3, 2023 16:00
Member
|
Moved to draft as the original commit changed and this needs to be cherry-picked again. |
The CreatedAt date was determined from the volume's `_data` directory (`/var/lib/docker/volumes/<volumename>/_data`). However, when initializing a volume, this directory is updated, causing the date to change. Instead of using the `_data` directory, use its parent directory, which is not updated afterwards, and should reflect the time that the volume was created. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 01fd23b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
No worries; it was a bit of a gamble; I re-cherry-picked |
thaJeztah
force-pushed
the
23.0_backport_fix_volume_createdat
branch
from
January 3, 2023 16:56
b0e0d86 to
fe097e0
Compare
thaJeztah
marked this pull request as ready for review
January 3, 2023 16:56
neersighted
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CreatedAt date was determined from the volume's
_datadirectory (/var/lib/docker/volumes/<volumename>/_data). However, when initializing a volume, this directory is updated, causing the date to change.Instead of using the
_datadirectory, use its root directory, which is not updated afterwards, and should reflect the time that the volume was created.This is basically the same as the original PR, but uses
rootPathdirectly instead of manipulating thepath.- Description for the changelog
Volume's
CreatedAtdoesn't change when volume content is modified.