Fix volume CreatedAt being altered on initialization#44719
Merged
Merged
Fix volume CreatedAt being altered on initialization#44719
Conversation
Contributor
Author
|
@cpuguy83 PTAL |
thaJeztah
reviewed
Dec 31, 2022
|
|
||
| func (v *localVolume) CreatedAt() (time.Time, error) { | ||
| fileInfo, err := os.Stat(v.path) | ||
| fileInfo, err := os.Stat(v.rootPath) |
Member
There was a problem hiding this comment.
Oh, interesting; not sure why I didn't pick rootPath at the time; perhaps I wasn't sure if "rootPath" could have a different meaning. 🤔
Member
neersighted
requested changes
Jan 3, 2023
The CreatedAt date was determined from the volume's `_data` directory (`/var/lib/docker/volumes/<volumename>/_data`). However, when initializing a volume, this directory is updated, causing the date to change. Instead of using the `_data` directory, use its parent directory, which is not updated afterwards, and should reflect the time that the volume was created. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
fix-volume-createdat
branch
from
January 3, 2023 15:57
9c98d13 to
01fd23b
Compare
neersighted
approved these changes
Jan 3, 2023
cpuguy83
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CreatedAt date was determined from the volume's
_datadirectory (/var/lib/docker/volumes/<volumename>/_data). However, when initializing a volume, this directory is updated, causing the date to change.Instead of using the
_datadirectory, use its root directory, which is not updated afterwards, and should reflect the time that the volume was created.This is basically the same as the original PR, but uses
rootPathdirectly instead of manipulating thepath.- Description for the changelog
Volume's
CreatedAtdoesn't change when volume content is modified.