[release/9.1] Reuse Event Hubs client for health checks - #7628
#7628Merged
danmoseley merged 1 commit intoFeb 18, 2025
release/9.1microsoft/aspire:release/9.1from
backport/pr-7625-to-release/9.1microsoft/aspire:backport/pr-7625-to-release/9.1Copy head branch name to clipboard
Merged
[release/9.1] Reuse Event Hubs client for health checks#7628danmoseley merged 1 commit intorelease/9.1microsoft/aspire:release/9.1from backport/pr-7625-to-release/9.1microsoft/aspire:backport/pr-7625-to-release/9.1Copy head branch name to clipboard
danmoseley merged 1 commit into
release/9.1microsoft/aspire:release/9.1from
backport/pr-7625-to-release/9.1microsoft/aspire:backport/pr-7625-to-release/9.1Copy head branch name to clipboard
Conversation
github-actions
Bot
requested review from
eerhardt,
radical and
sebastienros
as code owners
February 15, 2025 05:42
eerhardt
reviewed
Feb 18, 2025
| [ConditionalFact] | ||
| public void HealthChecksClientsAreReused() | ||
| { | ||
| SkipIfHealthChecksAreNotSupported(); |
Member
There was a problem hiding this comment.
Shouldn't HealthChecks always be supported for EventHubs now? Why is this check needed?
Contributor
There was a problem hiding this comment.
I copied it from the base component class test. I assumed it didn't hurt. And it won't break if for any reason the heathcheck is not supported in a new or updated client. I'll remove it in main.
eerhardt
approved these changes
Feb 18, 2025
eerhardt
left a comment
Member
There was a problem hiding this comment.
LGTM. The test comment can be addressed in main if there is a code change necessary.
sebastienros
requested review from
davidfowl
and removed request for
sebastienros
February 18, 2025 19:05
danmoseley
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7625 to release/9.1
/cc @sebastienros
Customer Impact
Each Event Hubs health check instance (attempt) will create a new client that won't be disposed potentially inducing memory leaks.
Testing
Verified manually and added a unit test for all EH clients.
Risk
Functional tests are passing. Low risk.
Regression?
New feature in 9.1: component health checks for Event Hubs.