Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Reuse Event Hubs client for health checks - #7625

#7625
Merged
sebastienros merged 1 commit into
mainmicrosoft/aspire:mainfrom
sebros/hubhealthcheckmicrosoft/aspire:sebros/hubhealthcheckCopy head branch name to clipboard
Feb 15, 2025
Merged

Reuse Event Hubs client for health checks#7625
sebastienros merged 1 commit into
mainmicrosoft/aspire:mainfrom
sebros/hubhealthcheckmicrosoft/aspire:sebros/hubhealthcheckCopy head branch name to clipboard

Conversation

@sebastienros

@sebastienros sebastienros commented Feb 15, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes #7537

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings February 15, 2025 00:06
Copilot AI reviewed Feb 15, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

@sebastienros
sebastienros merged commit b430409 into main Feb 15, 2025
@sebastienros
sebastienros deleted the sebros/hubhealthcheck branch February 15, 2025 05:41
@sebastienros

sebastienros commented Feb 15, 2025

Copy link
Copy Markdown
Contributor Author

/backport to release/9.1

@github-actions

github-actions Bot commented Feb 15, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13342254632

@github-actions github-actions Bot mentioned this pull request Feb 15, 2025
Merged
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments
@davidfowl davidfowl davidfowl approved these changes
@radical radical Awaiting requested review from radical radical is a code owner
@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EventHubs health checks create a new client on each health check

3 participants

@sebastienros @davidfowl
Morty Proxy This is a proxified and sanitized view of the page, visit original site.